Migrate rest of AlertDialogs to AppCompat#6001
Merged
Redirion merged 1 commit intoTeamNewPipe:devfrom Apr 7, 2021
TacoTheDank:appcompat-alertdialog
Merged
Migrate rest of AlertDialogs to AppCompat#6001Redirion merged 1 commit intoTeamNewPipe:devfrom TacoTheDank:appcompat-alertdialog
Redirion merged 1 commit intoTeamNewPipe:devfrom
TacoTheDank:appcompat-alertdialog
Conversation
AudricV
added
codequality
Redirion
approved these changes
Apr 6, 2021
Member
Redirion
left a comment
Redirion
left a comment
There was a problem hiding this comment.
looks good to me. Have you been able to test it a bit? In my opinion this is good to merge though.
Member
Author
|
@Redirion Yeah, I tested it a bit before, works fine. The dialogs don't really look different to me but I guess that's not really the point lol |
This was referenced Apr 11, 2021
Closed
tossj
pushed a commit
to tossj/NewPipe-legacy
that referenced
this pull request
Apr 23, 2021
…t-alertdialog Migrate rest of AlertDialogs to AppCompat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Fixes the following issue(s)
APK testing
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
Due diligence